From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 4/5] app/testpmd: enable queue ring size
	configure
Date: Mon, 23 Apr 2018 18:45:01 +0100
Message-ID: <c2082c58-6acc-28dc-2612-e1bb22f114e1@intel.com>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
 <20180422115824.105219-1-qi.z.zhang@intel.com>
 <20180422115824.105219-5-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: konstantin.ananyev@intel.com, dev@dpdk.org, beilei.xing@intel.com,
 jingjing.wu@intel.com, wenzhuo.lu@intel.com
To: Qi Zhang <qi.z.zhang@intel.com>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id E6A6B1DBB
 for <dev@dpdk.org>; Mon, 23 Apr 2018 19:45:06 +0200 (CEST)
In-Reply-To: <20180422115824.105219-5-qi.z.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/22/2018 12:58 PM, Qi Zhang wrote:
> Add command to change specific queue's ring size configure,
> the new value will only take effect after command that restart
> the device(port stop <port_id>/port start <port_id>) or command
> that setup the queue(port <port_id> rxq <qid> setup) at runtime.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  app/test-pmd/cmdline.c                      | 102 ++++++++++++++++++++++++++++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |   9 +++
>  2 files changed, 111 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b50e11e60..22e4d4585 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -846,6 +846,11 @@ static void cmd_help_long_parsed(void *parsed_result,
>  			"port config mtu X value\n"
>  			"    Set the MTU of port X to a given value\n\n"
>  
> +			"port config (port_id) (rxq|txq) (queue_id) ring_size (value)\n"
> +			"    Set a rx/tx queue's ring size configuration, the new"
> +			" value will take effect after command that (re-)start the port"
> +			" or command that setup the specific queue\n\n"

"port config all rxq|txq|rxd|txd <value>" is used to set number of queues (rxq)
or number of descriptors in queue (rxd).

Problem is this is not flexible and your version is better.

What do you think removing old rxd|txd part with this patch, to prevent duplication?