From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v3 6/6] doc: advertise bucket mempool driver
Date: Thu, 26 Apr 2018 12:50:30 +0300
Message-ID: <c21c3a60-be2f-c6a2-f3bf-6f33b218f9b4@solarflare.com>
References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com>
 <1524673942-22726-7-git-send-email-arybchenko@solarflare.com>
 <4297121.oP7HX5CK1i@xps> <5302029.6bfcN0d6QB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 39D1D5F2C
 for <dev@dpdk.org>; Thu, 26 Apr 2018 11:50:41 +0200 (CEST)
In-Reply-To: <5302029.6bfcN0d6QB@xps>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 04/26/2018 01:04 AM, Thomas Monjalon wrote:
> 25/04/2018 23:56, Thomas Monjalon:
>> Usually it is better to update the release notes in the main patch
>> implementing the feature (probably the first one in this case).
>> You can also update it step by step in several patches.

Yes, will do in v4.

>> 25/04/2018 18:32, Andrew Rybchenko:
>>> --- a/doc/guides/rel_notes/release_18_05.rst
>>> +++ b/doc/guides/rel_notes/release_18_05.rst
>>> @@ -147,7 +147,15 @@ New Features
>>>     compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver
>>>     to vhost lib, when virtio connected, with the help of the registered vDPA
>>>     driver the assigned VF gets configured to Rx/Tx directly to VM's virtio
>>> -  vrings.
>> Removing this last word is probably a mistake.

My bad, very inaccurate rebase.

>>> +
>>> +* **Added bucket mempool driver.**
>>> +
>>> +  Added bucket mempool driver which provides a way to allocate contiguous
>>> +  block of objects.
>>> +  Number of objects in the block depends on how many objects fit in
>>> +  RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
>>> +  The number may be obtained using rte_mempool_ops_get_info() API.
>>> +  Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API.
> Please add this feature at the beginning of the list (as the first one).

Will do in v4

> If possible, I would prefer you rebase on top of the mainline
> (looks to be next-net here).

Yes, that's right. Will do in v4.

> Thanks and sorry for nit-picking, I'm testing your stamina :)

You're welcome. Thanks for review notes.

Andrew.