From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 00/18] net/ixgbe: Consistent filter API
Date: Thu, 12 Jan 2017 15:43:26 +0000
Message-ID: <c224544b-0b9a-99c6-10f5-93184caef6ed@intel.com>
References: <1484210439-61746-1-git-send-email-wei.zhao1@intel.com>
 <1484212665-1635-1-git-send-email-wei.zhao1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id AED8E5A44
 for <dev@dpdk.org>; Thu, 12 Jan 2017 16:43:29 +0100 (CET)
In-Reply-To: <1484212665-1635-1-git-send-email-wei.zhao1@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Wei,

On 1/12/2017 9:17 AM, Wei Zhao wrote:
> The patches mainly finish following functions:
> 1) Store and restore all kinds of filters.
> 2) Parse all kinds of filters.
> 3) Add flow validate function.
> 4) Add flow create function.
> 5) Add flow destroy function.
> 6) Add flow flush function.

Overall patchset looks good, only major comment is adding more comments
on parse_filter functions for expected/valid rules.

You can keep Beilei's Ack for next version of the patchset.

Thanks,
ferruh