From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 1/2] net/bnxt: switch to the new offload API Date: Thu, 5 Apr 2018 15:36:00 +0100 Message-ID: References: <20180402222501.62165-1-ajit.khaparde@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Ajit Khaparde , dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D04B11C6AA for ; Thu, 5 Apr 2018 16:36:02 +0200 (CEST) In-Reply-To: <20180402222501.62165-1-ajit.khaparde@broadcom.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/2/2018 11:25 PM, Ajit Khaparde wrote: > Update bnxt PMD to new ethdev offloads API. > > Signed-off-by: Ajit Khaparde > -- > v1->v2: return an error if requested offload flags do not > match supported offload capabilities. > v2->v3: modify the code based on review comments. <...> > @@ -516,6 +526,20 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev) > { > struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private; > + uint64_t tx_offloads = eth_dev->data->dev_conf.txmode.offloads; > + uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads; > + > + if (tx_offloads != (tx_offloads & BNXT_DEV_TX_OFFLOAD_SUPPORT)) { > + PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n", > + tx_offloads, BNXT_DEV_TX_OFFLOAD_SUPPORT); > + return -ENOTSUP; > + } > + > + if (rx_offloads != (rx_offloads & BNXT_DEV_RX_OFFLOAD_SUPPORT)) { > + PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n", > + rx_offloads, BNXT_DEV_RX_OFFLOAD_SUPPORT); > + return -ENOTSUP; > + } This is causing i686 build error [1]. [1] In file included from .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:43:0: .../dpdk/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_dev_configure_op’: .../dpdk/drivers/net/bnxt/bnxt.h:341:50: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=] rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \ ^ .../dpdk/drivers/net/bnxt/bnxt.h:345:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ PMD_DRV_LOG_RAW(level, fmt, ## args) ^~~~~~~~~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:528:3: note: in expansion of macro ‘PMD_DRV_LOG’ PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n", ^~~~~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:528:47: note: format string is defined here PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n", ~~^ %llx In file included from .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:43:0: .../dpdk/drivers/net/bnxt/bnxt.h:341:50: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=] rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \ ^ .../dpdk/drivers/net/bnxt/bnxt.h:345:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ PMD_DRV_LOG_RAW(level, fmt, ## args) ^~~~~~~~~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:534:3: note: in expansion of macro ‘PMD_DRV_LOG’ PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n", ^~~~~~~~~~~ .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:534:47: note: format string is defined here PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n", ~~^ %llx cc1: all warnings being treated as errors