From mboxrd@z Thu Jan  1 00:00:00 1970
From: "David Harton (dharton)" <dharton@cisco.com>
Subject: Re: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit
 multicast addresses
Date: Wed, 13 Sep 2017 02:38:08 +0000
Message-ID: <c252160aa1d643c4a2d938b47e816233@XCH-RCD-016.cisco.com>
References: <20170822222146.36912-1-dharton@cisco.com>
 <20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab>
 <94479800C636CB44BD422CB454846E013201BD5A@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Xing, Beilei" <beilei.xing@intel.com>, David Harton
 <dharton@cpp-rtpbld-31.cpprtplab>, "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77])
 by dpdk.org (Postfix) with ESMTP id 96C5D2BC9
 for <dev@dpdk.org>; Wed, 13 Sep 2017 04:38:10 +0200 (CEST)
In-Reply-To: <94479800C636CB44BD422CB454846E013201BD5A@SHSMSX101.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Beilei,

> -----Original Message-----
> From: Xing, Beilei [mailto:beilei.xing@intel.com]
>=20
> Hi Harton,
>=20
> > -----Original Message-----
> > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab]
> >
> > From: David Harton <dharton@cisco.com>
> >
> > The i40e maintains a single MAC filter table for both unicast and
> > multicast addresses.  The i40e_validate_mac_addr function was
> > preventing multicast addresses from being added to the table via
> > i40evf_add_mac_addr.  Fixed the issue by adjusting the check in
> i40evf_add_mac_addr.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address")
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
> > ---
> >
> > v2
> > * Removed multicast check in i40evf_add_mac_addr.
> >
> > v1
> > * Removed multicast check in i40e_validate_mac_addr.
> >
> >  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index f6d8293..5916d11 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -888,7 +888,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
> >  	int err;
> >  	struct vf_cmd_info args;
> >
> > -	if (i40e_validate_mac_addr(addr->addr_bytes) !=3D I40E_SUCCESS) {
> > +	if (is_zero_ether_addr(addr) !=3D I40E_SUCCESS) {
>=20
> Thanks for the patch, there's some mistake with my last comment.

Actually, I think the logic above works but I do agree it is confusing
but I wanted to use your suggestion to speed up the process. :)

> * @return
>  *   True  (1) if the given ethernet address is filled with zeros;
>  *   false (0) otherwise.
>  */
> According to the comment of is_zero_ether_addr function, return value
> should be 0 or 1.
> So you should use if (!is_zero_ether_addr(addr))  here.

I don't think so.  I think the logic that should be used is
if (is_zero_ether_addr(addr)) {
because we want to report an error if the addr is all 0's.

Please let me know if you agree and I'll post this patch instead.

Thanks,
Dave

>=20
> >  		PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
> >  			    addr->addr_bytes[0], addr->addr_bytes[1],
> >  			    addr->addr_bytes[2], addr->addr_bytes[3],
> > --
> > 2.10.3.dirty