From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH] build: fix default arm64 build instruction level support Date: Wed, 11 Apr 2018 12:30:07 +0530 Message-ID: References: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> <20180410141648.GA164988@bricha3-MOBL.ger.corp.intel.com> <59AF69C657FD0841A61C55336867B5B072275DC5@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "pbhagavatula@caviumnetworks.com" , "stable@dpdk.org" , "jerin.jacob@caviumnetworks.com" To: "Richardson, Bruce" , "herbert.guan@arm.com" , "hemant.agrawal@nxp.com" , Shreyansh Jain Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B072275DC5@IRSMSX103.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2018 7:49 PM, Richardson, Bruce wrote: > Resend, fixing "To" recipients. > >> -----Original Message----- >> From: Bruce Richardson [mailto:bruce.richardson@intel.com] >> Sent: Tuesday, April 10, 2018 3:17 PM >> To: Jerin Jacob >> Cc: dev@dpdk.org; herbert.guan@arm.com; pbhagavatula@caviumnetworks.com; >> hemant.agrawal@nxp.com; stable@dpdk.org; jerin.jacob@caviumnetworks.com >> Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction >> level support >> >> On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: >>> The make based build system has crc+crypto instruction support for the >>> default arm64 build. >>> http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 >>> >>> This patch fixes the disparity with meson build flags for armv8. >>> As a bonus, This patch fixes the following errors with ip_pipeline >>> example application. >>> >>> Assembler messages: >>> Error: selected processor does not support `crc32cx w3,w3,x0' >>> >>> Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for >>> ARM") >>> >>> Cc: herbert.guan@arm.com >>> Cc: pbhagavatula@caviumnetworks.com >>> Cc: bruce.richardson@intel.com >>> Cc: hemant.agrawal@nxp.com >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Jerin Jacob >>> --- >> >> Hemant, Shreyansh, Herbert, >> >> any issues with this patch on your side? Can one of you please ack it. It >> allows use of "-Dexamples=all" when doing cross-builds for all the >> different arm targets in the config dir. Without it, ip_pipeline fails to >> build for many of the targets. >> >> /Bruce > Acked-by: Hemant Agrawal