From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 7/7] net/qede: restrict maximum queues for PF/VF Date: Mon, 12 Dec 2016 20:10:36 +0000 Message-ID: References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com> <1480733039-13046-7-git-send-email-harish.patil@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Dept-Eng DPDK Dev To: Harish Patil , "dev@dpdk.org" Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7691E2E83 for ; Mon, 12 Dec 2016 21:10:39 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/12/2016 7:29 PM, Harish Patil wrote: > >> On 12/3/2016 2:43 AM, Harish Patil wrote: >>> Fix to adverstise max_rx_queues by taking into account the number >> >> s/adverstise/advertise > > Will correct that, thanks. > >> >>> of PF connections instead of returning max_queues supported by the >>> HW. >> >> Can you please describe what is the effect, what happens if this is not >> fixed, and driver keeps reporting max_queues supported by the HW? > > We have tested up to 32 Rx/Tx queues across different qede devices, so I > would like to advertise only those many. > Hope that is okay. That is OK, can you please add this information to the commit log, otherwise it is not possible to know the reasoning of the change just with code. Thanks. > >> >>> >>> Fixes: 2ea6f76a ("qede: add core driver") >>> >>> Signed-off-by: Harish Patil >>> --- >> <...> >> > >