From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] net/virtio: fix incorrect cast of void * Date: Thu, 14 Dec 2017 15:49:32 +0100 Message-ID: References: <20171214143343.28785-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Didier Pallard , stable@dpdk.org To: Olivier Matz , dev@dpdk.org, Yuanhan Liu Return-path: In-Reply-To: <20171214143343.28785-1-olivier.matz@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/14/2017 03:33 PM, Olivier Matz wrote: > From: Didier Pallard > > The rx_queues and tx_queues fields of the data structure points to a struct > virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. > > It does not trigger any bug because pointer is not dereferenced inside the > function, but it can become a bug if this code is copy/pasted and vq is > dereferenced. > > Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue") > Cc: stable@dpdk.org > > Signed-off-by: Didier Pallard > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index c0ba83b06..b398f9960 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -893,7 +893,7 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev, > /* Note: limit checked in rte_eth_xstats_names() */ > > for (i = 0; i < dev->data->nb_rx_queues; i++) { > - struct virtqueue *rxvq = dev->data->rx_queues[i]; > + struct virtnet_rx *rxvq = dev->data->rx_queues[i]; > if (rxvq == NULL) > continue; > for (t = 0; t < VIRTIO_NB_RXQ_XSTATS; t++) { > @@ -906,7 +906,7 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev, > } > > for (i = 0; i < dev->data->nb_tx_queues; i++) { > - struct virtqueue *txvq = dev->data->tx_queues[i]; > + struct virtnet_tx *txvq = dev->data->tx_queues[i]; > if (txvq == NULL) > continue; > for (t = 0; t < VIRTIO_NB_TXQ_XSTATS; t++) { > Reviewed-by: Maxime Coquelin Thanks, Maxime