From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix Date: Tue, 26 Jun 2018 12:06:24 +0100 Message-ID: References: <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stable@dpdk.org To: ido goshen Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/20/2018 7:22 PM, Ferruh Yigit wrote: > On 6/19/2018 3:37 PM, ido goshen wrote: >> Fixes: 4c173302c307 ("pcap: add new driver") >> Cc: stable@dpdk.org >> >> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper >> and not loop num_of_queue times >> The num_of_queue loop is already acheived by the caller rte_kvargs_process >> >> Fixes: >> 1. Opens N requested pcaps/dumpers instead of N^2 >> 2. Leak of pcap/dumper's which are being overwritten by >> the sequential calls to open_rx/tx_pcap/iface functions >> 3. Use the filename/iface args per queue and not just the last one >> that overwrites the previous names >> >> Signed-off-by: ido goshen > > For series, > Acked-by: Ferruh Yigit Series applied to dpdk-next-net/master, thanks.