From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markos Chandras Subject: Re: [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions Date: Tue, 4 Apr 2017 13:50:06 +0100 Message-ID: References: <20170404123211.5185-1-ndas@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Nirmoy Das , dev@dpdk.org Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by dpdk.org (Postfix) with ESMTP id 4F0B12BF5 for ; Tue, 4 Apr 2017 14:50:07 +0200 (CEST) Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E5C3BAAB1 for ; Tue, 4 Apr 2017 12:50:06 +0000 (UTC) In-Reply-To: <20170404123211.5185-1-ndas@suse.de> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nirmoy, On 04/04/2017 01:32 PM, Nirmoy Das wrote: > fixes: > error: In the GNU C Library, "makedev" is defined > by . For historical compatibility, it is > currently defined by as well, but we plan to > remove this soon. To use "makedev", include > directly. If you did not intend to use a system-defined macro > "makedev", you should undefine it after including . [-Werror] > dev = makedev(major, minor); > You forgot the 'Signed-off-by' line which is required for patches. See doc/guides/contributing/patches.rst -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg