From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH] crypto: recognize OP_TYPE_UNDEFINED in
 rte_crypto_op_pool_create
Date: Tue, 9 Oct 2018 18:21:50 +0530
Message-ID: <c37c59fb-fa28-70ee-be1f-cc8777ee8bf2@nxp.com>
References: <201810022008.w92K8B2r031185@lectura.cs.arizona.edu>
 <cf3e2b32-4055-a94a-4763-8b8de408ceda@nxp.com>
 <CANsAqf5BD+FohUT_-mGRM6ZzN9FtS7oWvH8UFJ6vGc7X2bACKw@mail.gmail.com>
 <9e19271f-714f-514d-4d0f-096f553654f3@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Junxiao Shi <git@mail1.yoursunny.com>, dev@dpdk.org
To: yoursunny <sunnylandh@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76])
 by dpdk.org (Postfix) with ESMTP id 6295C1B4E9
 for <dev@dpdk.org>; Tue,  9 Oct 2018 14:52:09 +0200 (CEST)
In-Reply-To: <9e19271f-714f-514d-4d0f-096f553654f3@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Also change title to
crypto: fix element size for undefined crypto op

On 10/9/2018 4:41 PM, Akhil Goyal wrote:
>
>
> On 10/9/2018 4:28 PM, yoursunny wrote:
>> Hi Akhil
>>
>> The documentation of rte_crypto_op_pool_create indicates that _UNDEFINED
>> creates a pool that supports both symmetric and assymetric crypto. This
>> change makes the code consistent with documentation.
>>
>> Yours, Junxiao
> Please add this information in the patch description and this should 
> be marked as a fix.
>
> Please also add
> Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op 
> oriented")
>
> and cc stable@dpdk.org
>> On Tue, Oct 9, 2018 at 06:51 Akhil Goyal <akhil.goyal@nxp.com> wrote:
>>
>>> Hi  Junxiao,
>>>
>>> On 10/3/2018 12:35 AM, Junxiao Shi wrote:
>>>> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
>>>> ---
>>>>    lib/librte_cryptodev/rte_cryptodev.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
>>> b/lib/librte_cryptodev/rte_cryptodev.c
>>>> index 63ae23f..3d6f474 100644
>>>> --- a/lib/librte_cryptodev/rte_cryptodev.c
>>>> +++ b/lib/librte_cryptodev/rte_cryptodev.c
>>>> @@ -1477,6 +1477,8 @@ rte_crypto_op_pool_create(const char *name, enum
>>> rte_crypto_op_type type,
>>>>                elt_size += sizeof(struct rte_crypto_sym_op);
>>>>        } else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) {
>>>>                elt_size += sizeof(struct rte_crypto_asym_op);
>>>> +     } else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) {
>>>> +             elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op),
>>> sizeof(struct rte_crypto_asym_op));
one more nit..
The line is beyond 80 characters.
Before sending the patch you should run checkpatch script.
>>>>        } else {
>>>>                CDEV_LOG_ERR("Invalid op_type\n");
>>>>                return NULL;
>>> Could you please explain the need for this change. If there is some 
>>> type
>>> which is missing, we can add that.
>>> defining the size of undefined op type does not make sense.
>>>
>>> -Akhil
>>>
>