From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/mlx: update C compliance standard Date: Fri, 30 Jun 2017 18:47:11 +0100 Message-ID: References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Nelio Laranjeiro , dev@dpdk.org To: Adrien Mazarguil Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CCEFF2C37 for ; Fri, 30 Jun 2017 19:47:16 +0200 (CEST) In-Reply-To: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/30/2017 6:19 PM, Adrien Mazarguil wrote: > This commit addresses a compilation issue against Glibc >= 2.25, which > implements assert() through a nonstandard ({ }) construct. Such constructs > can normally not be used without __extension__ keyword when -pedantic is > enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode. > > While assert.h checks for the compiler ability to support GNU extensions, > Clang, unlike GCC, does not allow the above syntax when combining > -std=gnu99 with -pedantic. > > Work around missing keyword by moving these PMDs to a stricter compliance > standard without GNU extensions but properly checked by Glibc. Doing so is > supported on the DPDK side since includes have been cleaned up. > > Signed-off-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.