From: Jacob Keller <jacob.e.keller@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
"Hore, Soumyadeep" <soumyadeep.hore@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Greenwalt, Paul" <paul.greenwalt@intel.com>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"Jiale, SongX" <songx.jiale@intel.com>
Subject: Re: [PATCH] net/iavf: check PTP capabilities during init
Date: Tue, 25 Nov 2025 15:57:10 -0800 [thread overview]
Message-ID: <c6635526-a576-44ec-89f1-985779ba0ee0@intel.com> (raw)
In-Reply-To: <aSWrIkJwhbsf7YvI@bricha3-mobl1.ger.corp.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]
On 11/25/2025 5:12 AM, Bruce Richardson wrote:
> On Tue, Nov 25, 2025 at 10:30:37AM +0000, Hore, Soumyadeep wrote:
>> Hi Jacob,
>>
>> Currently PTP features are not enabled in DPDK. We only have the Rx timestamp API in place. Typically the change that you want needs to be implemented in ethdev_ops.timesync_enable(), which is not implemented.
>>
> At this stage we are post final RC for 25.11, so taking this patch would be
> risky anyway. Let's target 26.03 for this, and then look to backport to
> 25.11.1
>
> Thanks,
> /Bruce
Sure. In that case i think we need to revert the other change that
checked the RX_TIMESTAMP flag as it corrected one issue but caused a
regression in Rx timestamp offload when it *is* functional.
I think its commit d21c2fe6e5a1 ("net/iavf: fix check for PF Rx
timestamp support"). That commit without this fix will incorrectly
prevent enabling Rx timestamps.
Thanks,
Jake
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2025-11-25 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 23:39 [PATCH] net/iavf: check PTP capabilities during init Jacob Keller
2025-11-24 12:09 ` Bruce Richardson
2025-11-24 21:34 ` Jacob Keller
2025-11-24 15:45 ` Patrick Robb
2025-11-25 10:30 ` Hore, Soumyadeep
2025-11-25 13:12 ` Bruce Richardson
2025-11-25 23:57 ` Jacob Keller [this message]
2025-11-25 22:07 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6635526-a576-44ec-89f1-985779ba0ee0@intel.com \
--to=jacob.e.keller@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=paul.greenwalt@intel.com \
--cc=songx.jiale@intel.com \
--cc=soumyadeep.hore@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).