From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 10/21] vhost: initialize vrings IOTLB caches
Date: Mon, 4 Sep 2017 17:45:01 +0200
Message-ID: <c67149e9-1d69-2de8-f89a-f1e89665935a@redhat.com>
References: <20170831095023.21037-1-maxime.coquelin@redhat.com>
 <20170831095023.21037-11-maxime.coquelin@redhat.com>
 <bbeb5372-d613-0bf4-131d-1060be708408@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com
To: Remy Horton <remy.horton@intel.com>, dev@dpdk.org, yliu@fridaylinux.org,
 jfreiman@redhat.com, tiwei.bie@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 935CF6841
 for <dev@dpdk.org>; Mon,  4 Sep 2017 17:45:16 +0200 (CEST)
In-Reply-To: <bbeb5372-d613-0bf4-131d-1060be708408@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Remy,

On 09/04/2017 03:57 PM, Remy Horton wrote:
> 
> On 31/08/2017 10:50, Maxime Coquelin wrote:
> [..]
>> +reset_vring_queue(struct virtio_net *dev, uint32_t vring_idx)
>>  {
>> +    struct vhost_virtqueue *vq = dev->virtqueue[vring_idx];
>>      int callfd;
> 
> Probably ought to have a bounds check on vring_idx..

Indeed, you are right. I'll fix it in next round.

Thanks,
Maxime