From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1] app/pdump: add check for PCAP PMD
Date: Tue, 6 Mar 2018 11:57:34 +0000
Message-ID: <c684adb2-b2ee-ceee-3ccd-f13a7a8f3433@intel.com>
References: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com>
 <6cb37db7-9efd-93de-0136-d327f41f9879@intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19DE9B@BGSMSX101.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 000174C71
 for <dev@dpdk.org>; Tue,  6 Mar 2018 12:57:37 +0100 (CET)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19DE9B@BGSMSX101.gar.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/6/2018 8:45 AM, Varghese, Vipin wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Monday, March 5, 2018 2:33 PM
>> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Pattan,
>> Reshma <reshma.pattan@intel.com>
>> Cc: Mcnamara, John <john.mcnamara@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD
>>
>> On 3/5/2018 7:57 AM, Vipin Varghese wrote:
>>> dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to
>>> the device-queue pair. Updating Makefile to check for the same.
>>>
>>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>>> ---
>>>  app/pdump/Makefile | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/app/pdump/Makefile b/app/pdump/Makefile index
>>> bd3c208..038a34f 100644
>>> --- a/app/pdump/Makefile
>>> +++ b/app/pdump/Makefile
>>> @@ -3,6 +3,10 @@
>>>
>>>  include $(RTE_SDK)/mk/rte.vars.mk
>>>
>>> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) $(error "Please enable
>>> +CONFIG_RTE_LIBRTE_PMD_PCAP") endif
>>
>> pdump is enabled default, so won't this break the default build?
> 
> Yes, you are right it will fail. Which then forces the user to enable PCAP.

We shouldn't break the default build because of missing dependencies.

> 
>>
>> What about moving this to lib/librte_pdump, convert $(error ..) to $(warning ..)
>> and disable CONFIG_RTE_LIBRTE_PDUMP there?
> 
> If we set to warning and there are no PCAP headers in build system. The application gets built, but will fail internally becz the pcap API will fails during execution.

if CONFIG_RTE_LIBRTE_PDUMP disabled application won't be compiled

> 
>>
>>> +
>>>  ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y)
>>>
>>>  APP = dpdk-pdump
>>>
>