From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] vfio: fix read-after-free on getting container fd Date: Fri, 26 Oct 2018 15:04:27 +0100 Message-ID: References: <20181025104911.137496-1-dariusz.stojaczyk@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jianfeng.tan@intel.com, stable@dpdk.org To: Darek Stojaczyk , dev@dpdk.org Return-path: In-Reply-To: <20181025104911.137496-1-dariusz.stojaczyk@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25-Oct-18 11:49 AM, Darek Stojaczyk wrote: > We were reading some memory just after freeing it. > > Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel") > Cc: jianfeng.tan@intel.com > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c > index d7268e4ce..fc3c7b870 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c > @@ -1034,8 +1034,9 @@ rte_vfio_get_container_fd(void) > mp_rep = &mp_reply.msgs[0]; > p = (struct vfio_mp_param *)mp_rep->param; > if (p->result == SOCKET_OK && mp_rep->num_fds == 1) { > + vfio_container_fd = mp_rep->fds[0]; > free(mp_reply.msgs); > - return mp_rep->fds[0]; > + return vfio_container_fd; > } > free(mp_reply.msgs); > } > Acked-by: Anatoly Burakov -- Thanks, Anatoly