From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v8 00/15] common linkstatus functions Date: Fri, 16 Mar 2018 10:31:04 +0000 Message-ID: References: <20180126020151.979-1-stephen@networkplumber.org> <58d25cba-6586-71c6-78c0-a4e200c0f431@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Stephen Hemminger , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2F445548B for ; Fri, 16 Mar 2018 11:31:07 +0100 (CET) In-Reply-To: <58d25cba-6586-71c6-78c0-a4e200c0f431@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/15/2018 5:38 PM, Ferruh Yigit wrote: > On 1/26/2018 2:01 AM, Stephen Hemminger wrote: >> While writing hyper-v driver, noticed a lot of unnecessary >> duplication of code in drivers for handling the eth_dev link status >> information. While consolidating this, it also became obvious that >> some drivers behave differently for no good reason. >> >> It also was a good chance to introduce atomic exchange primitives >> in EAL because there are other places using cmpset where not >> necessary (such as bonding). >> >> Mostly only compile tested only, don't have all of the hardware >> available (except ixgbe and virtio) to test. >> >> v8 >> - fix typo in 32bit exchange >> - fix build of dpaa2 >> - go back to same return value as original code >> - reduce number of lines changed >> >> v7 >> - add exchange functions for PPC64 >> - move linkstatus helpers to rte_ethdev_driver >> - rebase to 18.02 >> >> Stephen Hemminger (15): >> eal: introduce atomic exchange operation >> ethdev: add linkstatus get/set helper functions >> net/virtio: use eth_linkstatus_set >> net/vmxnet3: use rte_eth_linkstatus_set >> net/dpaa2: use rte_eth_linkstatus_set >> net/nfp: use rte_eth_linkstatus functions >> net/e1000: use rte_eth_linkstatus helpers >> net/ixgbe: use rte_eth_linkstatus functions >> net/sfc: use new rte_eth_linkstatus functions >> net/i40e: use rte_eth_linkstatus functions >> net/liquidio: use rte_eth_linkstatus_set >> net/thunderx: use rte_eth_linkstatus_set >> net/szedata: use _rte_eth_linkstatus_set >> net/octeontx: use rte_eth_linkstatus_set >> net/enic: use rte_eth_linkstatus_set > > For series > Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/master, thanks. (Need to resolve some conflicts, specially in i40e and vmxnet3, please verify final patches.)