From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 04/18] net/ixgbe: restore n-tuple filter Date: Tue, 20 Dec 2016 16:58:58 +0000 Message-ID: References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com> <1480675394-59179-5-git-send-email-wei.zhao1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 740E9FBA1 for ; Tue, 20 Dec 2016 17:59:01 +0100 (CET) In-Reply-To: <1480675394-59179-5-git-send-email-wei.zhao1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > Add support for restoring n-tuple filter in SW. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: wei zhao1 > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 131 +++++++++++++++++++++++++-------------- > 1 file changed, 83 insertions(+), 48 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c <...> > @@ -2482,6 +2496,7 @@ ixgbe_dev_start(struct rte_eth_dev *dev) > > /* resume enabled intr since hw reset */ > ixgbe_enable_intr(dev); > + ixgbe_filter_restore(dev); Just to double check, when you stop the device does 5tuple_filter reset? If not reset, will adding same filters cause any problem? > > return 0; > <...>