From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Rawat Subject: Re: [PATCH v8 03/10] eal: add new rte_os.h header to build system Date: Tue, 2 Apr 2019 15:11:57 -0700 Message-ID: References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> <2058052.CBssHhMYLK@xps> <9537388.5AKJxibmNW@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com To: Thomas Monjalon Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F0AEE4CBD for ; Wed, 3 Apr 2019 00:11:58 +0200 (CEST) In-Reply-To: <9537388.5AKJxibmNW@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/2/2019 1:47 PM, Thomas Monjalon wrote: > 02/04/2019 21:56, Thomas Monjalon: >> 02/04/2019 05:54, Anand Rawat: >>> Added rte_os.h files to support OS specific functionality. >>> Updated build system to contain OS headers in the include >>> path. >>> >>> Signed-off-by: Anand Rawat >>> Reviewed-by: Pallavi Kadam >>> --- >>> --- a/meson.build >>> +++ b/meson.build >>> -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') >>> +global_inc = include_directories('.', 'config', >>> + 'lib/librte_eal/common/include', >>> + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) >> >> After having worked on rte_kni_common.h which is only in Linux, >> I think we should add rte_os.h in meson file of each OS: >> - lib/librte_eal/linux/eal/meson.build >> - lib/librte_eal/freebsd/eal/meson.build >> - lib/librte_eal/windows/eal/meson.build > > I confirm: > "global_inc" is used in "includes" variable but not in "headers" variable, > so rte_os.h is not installed as other files in "headers". > We must fill "env_headers" which is pulled by: > headers = common_headers + env_headers > > I will fix it before merging in master if you agree. > > Agreed, env_headers need to be updated for rte_os.h. I have tested the same and will incorporating the changes in v9. Please update this patch with your fix. -- Anand Rawat