From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 4/4] netvsc: implement tx_done_cleanup
Date: Thu, 23 Aug 2018 15:46:04 +0100
Message-ID: <c78a8d97-e09d-1d85-56d8-31048ed4e26f@intel.com>
References: <20180809175008.5787-1-stephen@networkplumber.org>
 <20180809175008.5787-5-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 661DE2C60
 for <dev@dpdk.org>; Thu, 23 Aug 2018 16:46:07 +0200 (CEST)
In-Reply-To: <20180809175008.5787-5-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/9/2018 6:50 PM, Stephen Hemminger wrote:
> Add tx_done_cleanup ethdev hook to allow application to
> control if/when it wants completions to be handled.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  drivers/net/netvsc/hn_ethdev.c |  1 +
>  drivers/net/netvsc/hn_rndis.c  |  2 +-
>  drivers/net/netvsc/hn_rxtx.c   | 26 +++++++++++++++++++++-----
>  drivers/net/netvsc/hn_var.h    |  4 +++-
>  4 files changed, 26 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 148e6a33d682..2200ee319f98 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -547,6 +547,7 @@ static const struct eth_dev_ops hn_eth_dev_ops = {
>  	.allmulticast_disable   = hn_dev_allmulticast_disable,
>  	.tx_queue_setup		= hn_dev_tx_queue_setup,
>  	.tx_queue_release	= hn_dev_tx_queue_release,
> +	.tx_done_cleanup        = hn_dev_tx_done_cleanup,

This requires "Free Tx mbuf on demand" feature advertised as supported on
doc/guides/nics/features/netvsc.ini document. Will add while merging.