From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 09/25] bnxt: add support for set multicast addr list and MAC addr set Date: Mon, 29 May 2017 18:42:53 +0100 Message-ID: References: <20170526183941.80678-1-ajit.khaparde@broadcom.com> <20170526183941.80678-10-ajit.khaparde@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Ajit Khaparde , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9B4332C38 for ; Mon, 29 May 2017 19:42:56 +0200 (CEST) In-Reply-To: <20170526183941.80678-10-ajit.khaparde@broadcom.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/26/2017 7:39 PM, Ajit Khaparde wrote: > This patch adds support for set_mc_addr_list and > mac_addr_set dev_ops > > Signed-off-by: Ajit Khaparde > > -- > v1->v2: regroup related patches and incorporate other review comments > --- > doc/guides/nics/features/bnxt.ini | 1 + > drivers/net/bnxt/bnxt_ethdev.c | 70 ++++++++++++++++++++++++++++++++++++++- > drivers/net/bnxt/bnxt_hwrm.c | 13 +++++--- > drivers/net/bnxt/bnxt_hwrm.h | 2 +- > drivers/net/bnxt/bnxt_vnic.c | 7 +++- > drivers/net/bnxt/bnxt_vnic.h | 4 +++ > 6 files changed, 90 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini > index 78a738f..9b3cd94 100644 > --- a/doc/guides/nics/features/bnxt.ini > +++ b/doc/guides/nics/features/bnxt.ini > @@ -11,6 +11,7 @@ Unicast MAC filter = Y > Multicast MAC filter = Y > VLAN filter = Y > VLAN offload = Y > +Allmulticast mode = Y To have this support, .allmulticast_enable and .allmulticast_disable needs to implemented, these are already implemented in the PMD. This PMD implements ".set_mc_addr_list", I think this is "Multicast MAC filter", which seems already documented as supported. So, it is possible to have a separate patch to document "Allmulticast mode" > RSS reta update = Y > Basic stats = Y > Extended stats = Y <...>