From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v5 2/2] test: migrate custom handler test to
	stack handler
Date: Fri, 1 Jul 2016 09:32:47 +0200
Message-ID: <c8405171-ff84-a128-2874-8844cf442107@6wind.com>
References: <1467272502-56059-1-git-send-email-david.hunt@intel.com>
 <1467309909-123881-1-git-send-email-david.hunt@intel.com>
 <1467309909-123881-3-git-send-email-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com,
 shreyansh.jain@nxp.com
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 7B5F32BB5
 for <dev@dpdk.org>; Fri,  1 Jul 2016 09:32:57 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id r201so16591615wme.1
 for <dev@dpdk.org>; Fri, 01 Jul 2016 00:32:57 -0700 (PDT)
In-Reply-To: <1467309909-123881-3-git-send-email-david.hunt@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,

On 06/30/2016 08:05 PM, David Hunt wrote:
> After introducing the stack handler in the previous commit,
> we now have very similar code to the custom handler in test_mempool.c,
> which creates a custom mempool based on simple mallocs.
> The stack handler is a cleaner example of adding a new mempool handler,
> so this commit replaces the custom handler test with a stack
> handler test, and removes the custom handler code.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
>
> [...]
> 
> -static struct rte_mempool_ops mempool_ops_custom = {
> -	.name = "custom_handler",
> -	.alloc = custom_mempool_alloc,
> -	.free = custom_mempool_free,
> -	.enqueue = custom_mempool_enqueue,
> -	.dequeue = custom_mempool_dequeue,
> -	.get_count = custom_mempool_get_count,
> -};
> -
> -MEMPOOL_REGISTER_OPS(mempool_ops_custom);
> -
> -/*
>   * save the object number in the first 4 bytes of object data. All
>   * other bytes are set to 0.
>   */
> @@ -600,6 +507,7 @@ test_mempool(void)
>  	struct rte_mempool *mp_cache = NULL;
>  	struct rte_mempool *mp_nocache = NULL;
>  	struct rte_mempool *mp_ext = NULL;

mp_ext remains but is unused (it is just freed below).
It should be removed.