DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Sandeep Penigalapati <sandeep.penigalapati@intel.com>, <dev@dpdk.org>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
	Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
	Carolyn Wyborny <carolyn.wyborny@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] net/ixgbe: fix spurious MACsec event on E610
Date: Thu, 24 Sep 2026 11:34:04 +0200	[thread overview]
Message-ID: <c86e9c8e-7dc9-412f-a1ea-cbbeaead8bea@intel.com> (raw)
In-Reply-To: <20260923112519.10600-1-sandeep.penigalapati@intel.com>

On 9/23/2026 1:25 PM, Sandeep Penigalapati wrote:
> On 82599 and X5xx, EICR bit 0x00200000 is the MACsec PN-threshold cause
> (IXGBE_EICR_LINKSEC). On E610 the very same bit is redefined as the
> asynchronous firmware event cause (IXGBE_EICR_FW_EVENT). The interrupt
> handler decoded this bit unconditionally as LINKSEC and raised
> RTE_ETH_EVENT_MACSEC.
> 
> As E610 does not support MACsec, every firmware event (for example a
> link change) was reported to the application as a spurious MACsec event.
> In addition, the firmware events posted on the Admin Command Interface
> (ACI) receive queue were never drained, so the cause was not cleared.
> 
> Decode the bit per MAC type: on E610 treat it as a firmware event and
> drain the ACI receive queue until empty; keep the MACsec handling for
> the other MAC types. Link changes continue to be handled through the
> existing IXGBE_EICR_LSC path.
> 
> Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
> Cc: stable@dpdk.org
> Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
> ---

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2026-09-24  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 11:25 [PATCH] net/ixgbe: fix spurious MACsec event on E610 Sandeep Penigalapati
2026-09-24  9:34 ` Burakov, Anatoly [this message]
2026-09-24 10:41   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c86e9c8e-7dc9-412f-a1ea-cbbeaead8bea@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=dev@dpdk.org \
    --cc=jedrzej.jagielski@intel.com \
    --cc=piotr.kwapulinski@intel.com \
    --cc=sandeep.penigalapati@intel.com \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox