From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radu Nicolau Subject: Re: [PATCH] doc: added inline crypto feature Date: Wed, 8 Nov 2017 15:40:17 +0000 Message-ID: References: <1510147619-8701-1-git-send-email-radu.nicolau@intel.com> <14408406.FDyP0s16KU@xps> <6923ed2c-e62e-6454-0353-44f0c2afba08@intel.com> <7614729.vlcYnjIi5z@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A4FF61B1C1 for ; Wed, 8 Nov 2017 16:40:20 +0100 (CET) In-Reply-To: <7614729.vlcYnjIi5z@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/8/2017 3:13 PM, Thomas Monjalon wrote: > 08/11/2017 15:31, Radu Nicolau: >> On 11/8/2017 2:22 PM, Thomas Monjalon wrote: >>> 08/11/2017 14:26, Radu Nicolau: >>>> + >>>> +Inline crypto >>>> +------------- >>>> + >>>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details. >>> As there are several types of inline crypto, don't you think it deserves >>> several separate features? >> We don't differentiate in the offload, net, mbuf APIs; it's all >> "security offload". >> rte_security is the one that deals with different kinds of inline >> crypto, but in the NIC section it's all the same. > OK > How can we document which kind of inline crypto is supported with which device? I propose to change "See Security library for more details" to "See Security library and PMD documentation for more details" and update ixgbe.rst with an "inline crypto" section.