From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 3/3] app/testpmd: add Tx metadata debug
	commands
Date: Thu, 18 Oct 2018 08:56:38 +0100
Message-ID: <c8e6f272-880f-ab99-4a39-c940c8f6bb43@intel.com>
References: <1539254998-8555-1-git-send-email-dekelp@mellanox.com>
 <1539777829-64412-4-git-send-email-dekelp@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: shahafs@mellanox.com, dev@dpdk.org, orika@mellanox.com
To: Dekel Peled <dekelp@mellanox.com>, wenzhuo.lu@intel.com,
 jingjing.wu@intel.com, bernard.iremonger@intel.com, olivier.matz@6wind.com,
 adrien.mazarguil@6wind.com, thomas@monjalon.net, arybchenko@solarflare.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id E0FD75F25
 for <dev@dpdk.org>; Thu, 18 Oct 2018 09:56:43 +0200 (CEST)
In-Reply-To: <1539777829-64412-4-git-send-email-dekelp@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/17/2018 1:03 PM, Dekel Peled wrote:
> As described in [1],[2] this series adds option to set metadata value as
> match pattern when creating a new flow rule.
> 
> This patch introduces code for debug porpuse only.
> The new 'config' command takes a 32 bit value and stores it per port:
> 	port config <port_id> tx_metadata <value>
> 
> testpmd will add to any Tx packet sent from this port the metadata
> value, and set ol_flags accordingly.
> 
> A matching 'show' command is added to read the configured value:
> 	port config <port_id> tx_metadata <value>
> 
> [1] "ethdev: support metadata as flow rule criteria"
> [2] "app/testpmd: support metadata as flow rule criteria"
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

<...>

> @@ -857,6 +857,13 @@ Disable hardware insertion of a VLAN header in packets sent on a port::
>  
>     testpmd> tx_vlan reset (port_id)
>  
> +tx_metadata set
> +~~~~~~~~~~~~~~~
> +
> +Set metadata value to insert in packets sent to PMD::
> +
> +   testpmd> tx_metadata set (port_id) (value)
> +

Documentation is wrong, also show part is missing, can you please update it?