From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH] crypto/openssl: performance improvements Date: Tue, 15 Aug 2017 12:14:52 +0530 Message-ID: References: <20170728110738.28922-1-akhil.goyal@nxp.com> <20170728110738.28922-3-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "hemant.agrawal@nxp.com" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Doherty, Declan" Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0060.outbound.protection.outlook.com [104.47.34.60]) by dpdk.org (Postfix) with ESMTP id F2D748CF6 for ; Tue, 15 Aug 2017 08:45:07 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/14/2017 7:47 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Friday, July 28, 2017 12:08 PM >> To: dev@dpdk.org; Doherty, Declan >> Cc: De Lara Guarch, Pablo ; >> hemant.agrawal@nxp.com; Akhil Goyal >> Subject: [PATCH] crypto/openssl: performance improvements >> >> key and algo are added in the openssl ctx during session initialization >> instead of adding it for each packet. >> >> Also in case of HMAC the openssl APIs HMAC_XXX give better performance >> for all HMAC cases. >> >> Signed-off-by: Akhil Goyal > > Thanks for the patch, nice optimization! > Could you split this into two patches, as you are doing two different things here? > One for the first sentence and another one for the second sentence. > Also, as you do that, could you rename the title to be more explicit? > Like: crypto/openssl: initialize cipher key at session init > > Finally, I was looking at GCM, and I think it could benefit from this. > I will send a separate patch for it, unless you want to integrate it in this patchset yourself. > Ok I would split the patches. For GCM I will try to incorporate in this patchset, if I get some performance improvement, or I would send a different patch later if some issue comes. Thanks, Akhil