From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH 05/11] examples/ipsec-secgw: Fixed transport Date: Mon, 16 Oct 2017 10:30:27 +0100 Message-ID: References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <1507987683-12315-5-git-send-email-aviadye@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com, radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com, nelio.laranjeiro@6wind.com, thomas@monjalon.net To: aviadye@dev.mellanox.co.il, dev@dpdk.org, pablo.de.lara.guarch@intel.com, aviadye@mellanox.com Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5F5F91B5E0 for ; Mon, 16 Oct 2017 11:30:33 +0200 (CEST) In-Reply-To: <1507987683-12315-5-git-send-email-aviadye@dev.mellanox.co.il> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote: > From: Aviad Yehezkel > > Seems like transport was broken for a long time Commit message needs to be improved. Just mentioned what is wrong or how do you fix it. Given that it is a fix, you should start the commit title with "fix ..." then also add the 'fixes' line with commit that added the bug. That way you can easily see since when it was introduced. Thanks, Sergio > Signed-off-by: Aviad Yehezkel > --- > examples/ipsec-secgw/esp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c > index 70bb81f..56ad7a0 100644 > --- a/examples/ipsec-secgw/esp.c > +++ b/examples/ipsec-secgw/esp.c > @@ -306,8 +306,8 @@ esp_outbound(struct rte_mbuf *m, struct ipsec_sa *sa, > sizeof(struct esp_hdr) + sa->iv_len); > memmove(new_ip, ip4, ip_hdr_len); > esp = (struct esp_hdr *)(new_ip + ip_hdr_len); > + ip4 = (struct ip *)new_ip; > if (likely(ip4->ip_v == IPVERSION)) { > - ip4 = (struct ip *)new_ip; > ip4->ip_p = IPPROTO_ESP; > ip4->ip_len = htons(rte_pktmbuf_data_len(m)); > } else {