From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: harish.patil@qlogic.com
Subject: Re: [PATCH v2 01/10] bnx2x: Set cache line based on build configuration
Date: Fri, 30 Sep 2016 11:53:53 +0100 [thread overview]
Message-ID: <c9f3bb37-ee04-cabe-7587-b757fd4c5232@intel.com> (raw)
In-Reply-To: <1475144449-22176-1-git-send-email-3chas3@gmail.com>
Hi Chas,
On 9/29/2016 11:20 AM, Chas Williams wrote:
> Correctly hint the cache line size. Remove unused macros associated
> with the cache line size.
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> Acked-by: Harish Patil <harish.patil@qlogic.com>
> ---
Thank you for the updated patch.
When sending next version of the patchset, can you please take care of
following too:
- patch title should be:
"net/<driver>: all_lowercase_except_abbreviations"
so this patch subject becomes:
"net/bnx2x: set cache line based on build configuration"
- Rx/Tx should not be used as "RX" or "rx" in patch title
- There are three checkpatch warnings of same type on patch 10/10:
CHECK:SPACING: No space is necessary after a cast
#105: FILE: drivers/net/bnx2x/bnx2x.h:1461:
+ ((uintptr_t) sc->bar[BAR0].base_addr + offset)));
- Is ack from Harish for this patch only or for all patchset? Since this
patchset doesn't have a cover letter, if ack is for patchset please put
Acked-by line to each patch.
Thanks,
ferruh
prev parent reply other threads:[~2016-09-30 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 10:20 [PATCH v2 01/10] bnx2x: Set cache line based on build configuration Chas Williams
2016-09-29 10:20 ` [PATCH v2 02/10] bnx2x: Remove unused preprocessor symbols and code Chas Williams
2016-09-29 10:20 ` [PATCH v2 03/10] bnx2x: Remove delay during device startup Chas Williams
2016-09-29 10:20 ` [PATCH v2 04/10] bnx2x: Remove unused RX queue code Chas Williams
2016-09-29 10:20 ` [PATCH v2 05/10] bnx2x: Restrict RX mask flags sent to the PF Chas Williams
2016-09-30 10:45 ` Ferruh Yigit
2016-09-29 10:20 ` [PATCH v2 06/10] bnx2x: Replace macro with static function Chas Williams
2016-09-29 10:20 ` [PATCH v2 07/10] bnx2x: Serialize access to pf2vf mailbox Chas Williams
2016-09-30 10:45 ` Ferruh Yigit
2016-09-29 10:20 ` [PATCH v2 08/10] bnx2x: Check return codes during VF mailbox operation Chas Williams
2016-09-29 10:20 ` [PATCH v2 09/10] bnx2x: Don't return structs Chas Williams
2016-09-29 10:20 ` [PATCH v2 10/10] bnx2x: Merge debug register operations into headers Chas Williams
2016-09-30 18:16 ` Harish Patil
2016-09-30 10:53 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f3bb37-ee04-cabe-7587-b757fd4c5232@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).