From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 01/10] bnx2x: Set cache line based on
 build configuration
Date: Fri, 30 Sep 2016 11:53:53 +0100
Message-ID: <c9f3bb37-ee04-cabe-7587-b757fd4c5232@intel.com>
References: <1475144449-22176-1-git-send-email-3chas3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: harish.patil@qlogic.com
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 66C9A2B84
 for <dev@dpdk.org>; Fri, 30 Sep 2016 12:53:56 +0200 (CEST)
In-Reply-To: <1475144449-22176-1-git-send-email-3chas3@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Chas,

On 9/29/2016 11:20 AM, Chas Williams wrote:
> Correctly hint the cache line size.  Remove unused macros associated
> with the cache line size.
> 
> Fixes: 540a211084a7 ("bnx2x: driver core")
> 
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> Acked-by: Harish Patil <harish.patil@qlogic.com>
> ---

Thank you for the updated patch.

When sending next version of the patchset, can you please take care of
following too:

- patch title should be:
  "net/<driver>: all_lowercase_except_abbreviations"

  so this patch subject becomes:
  "net/bnx2x: set cache line based on build configuration"

- Rx/Tx should not be used as "RX" or "rx" in patch title


- There are three checkpatch warnings of same type on patch 10/10:

CHECK:SPACING: No space is necessary after a cast
#105: FILE: drivers/net/bnx2x/bnx2x.h:1461:
+                         ((uintptr_t) sc->bar[BAR0].base_addr + offset)));

- Is ack from Harish for this patch only or for all patchset? Since this
patchset doesn't have a cover letter, if ack is for patchset please put
Acked-by line to each patch.

Thanks,
ferruh