From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22310CD4F50 for ; Mon, 18 May 2026 13:18:55 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFAA8402D9; Mon, 18 May 2026 15:18:54 +0200 (CEST) Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by mails.dpdk.org (Postfix) with ESMTP id 96A92402B8; Mon, 18 May 2026 15:18:53 +0200 (CEST) Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 2460E14000E6; Mon, 18 May 2026 09:18:53 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Mon, 18 May 2026 09:18:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1779110333; x=1779196733; bh=Rt4FmgmEJgklcQT/i6+Od+g39GAnxV6g1R7S04NV2x0=; b= M73i1grq86oFNU49pQ2eEc5Euw57gQiAp3pifcYWvl2UMfIJG1hjD0WfjPddMfJR Rpv3Ed5ABwUNi91zZpJRVNhmEhGE8rnoxb+OMzAX1kbRayghWM9iQM3Bx4fW4crF qrUSiXGNGTvoF4YKsQLSmTgNUKfZr/Xgr0pe9svyBaHUHtwFZcuIsJEDQn70+V+6 IqAcNhvlmThNDIJifvD7qR4QYYdWsEQgQdpikztCFu1XeeD7QCZTeG4q5Wge0apZ hGZP27G2e+hJiyxAkUipwhdLTkqHzwTw6UKx2zWNnZc/lcm1FYkq3ha3JBkqc35z EqY/pnYrY7nPh5d/5TYHJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1779110333; x= 1779196733; bh=Rt4FmgmEJgklcQT/i6+Od+g39GAnxV6g1R7S04NV2x0=; b=b O8Q8cAmWpiqLwCQx/g5dwzVRxegO9gLv9PxUSZPNRefvm+VRIJYA6NiKVSTIJ5W/ jufF0Jcyh9ycsUgHbXbkWEmoYJBoDZqVRJHZIxywM3xtI176dUB+YeeFdtfRQusf tJSCdm+Ooxf8wfRkKv6+UZq0Gk+R3gwKs26RudpU0ic98bXdVOmNUUpFWctYqMwQ z8YylDE4RZ0UWma+srH9wxWKWL7T78Zkfc1Pv58pxwiB2JHbnctu76KlGVR4yNBe SAa94fLkmlHI7VXXqPvLqa7PjYTqehMAnFM9CVRU5A9O6H1Vs4kiIAyelt2omcon 7BqRF/+sTWZyR/Ci0oT/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddufeekleejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdv uefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeegpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopegurghvihgurdhmrghrtghhrghnugesrh gvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthht ohephhgrihihuhgvrdifrghnghesihhnthgvlhdrtghomhdprhgtphhtthhopehsthgrsg hlvgesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 May 2026 09:18:52 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Haiyue Wang , stable@dpdk.org Subject: Re: [PATCH] devtools: fix regex matching literal plus in patches Date: Mon, 18 May 2026 15:18:51 +0200 Message-ID: In-Reply-To: References: <20260505140352.3995590-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/05/2026 13:55, David Marchand: > On Tue, 5 May 2026 at 16:04, Thomas Monjalon wrote: > > > > In Extended Regular Expressions (ERE) as used in awk, > > '+' is a quantifier, not a literal character. > > The pattern /^+/ matches the start of any line > > instead of only lines beginning with a literal '+'. > > As a result, check_experimental_tags and check_internal_tags > > were matching context and removed lines in diffs, causing false positives. > > > > Use [+] character class to unambiguously match a literal '+'. > > > > Fixes: cfe3aeb170b2 ("remove experimental tags from all symbol definitions") > > Fixes: fba5af82adc8 ("eal: add internal ABI tag definition") > > Cc: stable@dpdk.org > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: David Marchand Applied