From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 2/7] net/bnxt: fix mtu configuration for the function Date: Thu, 29 Jun 2017 11:55:59 +0100 Message-ID: References: <20170629025142.19404-1-ajit.khaparde@broadcom.com> <20170629025142.19404-3-ajit.khaparde@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Ajit Khaparde , dev@dpdk.org Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 648BE2C2A for ; Thu, 29 Jun 2017 12:56:03 +0200 (CEST) In-Reply-To: <20170629025142.19404-3-ajit.khaparde@broadcom.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/29/2017 3:51 AM, Ajit Khaparde wrote: > Set the MTU of the device to MAX size possible. What was the failure with existing code? > Signed-off-by: Ajit Khaparde Can you please add the Fixes tag. > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index e237041..580b2d8 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -2023,8 +2023,7 @@ static int bnxt_hwrm_pf_func_cfg(struct bnxt *bp, int tx_rings) > HWRM_FUNC_CFG_INPUT_ENABLES_NUM_VNICS | > HWRM_FUNC_CFG_INPUT_ENABLES_NUM_HW_RING_GRPS); > req.flags = rte_cpu_to_le_32(bp->pf.func_cfg_flags); > - req.mtu = rte_cpu_to_le_16(bp->eth_dev->data->mtu + ETHER_HDR_LEN + > - ETHER_CRC_LEN + VLAN_TAG_SIZE); > + req.mtu = rte_cpu_to_le_16(BNXT_MAX_MTU); Just question, would this cause larger frames than expected in application? > req.mru = rte_cpu_to_le_16(bp->eth_dev->data->mtu + ETHER_HDR_LEN + > ETHER_CRC_LEN + VLAN_TAG_SIZE); > req.num_rsscos_ctxs = rte_cpu_to_le_16(bp->max_rsscos_ctx); >