From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342D1E7717F for ; Tue, 10 Dec 2024 06:13:00 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82BAE4029B; Tue, 10 Dec 2024 07:12:59 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 508E04025A for ; Tue, 10 Dec 2024 07:12:58 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Y6pJY1VjRzqTqC; Tue, 10 Dec 2024 14:11:09 +0800 (CST) Received: from dggemv703-chm.china.huawei.com (unknown [10.3.19.46]) by mail.maildlp.com (Postfix) with ESMTPS id B84E61800FE; Tue, 10 Dec 2024 14:12:56 +0800 (CST) Received: from kwepemn100005.china.huawei.com (7.202.194.108) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Dec 2024 14:12:56 +0800 Received: from kwepemd500024.china.huawei.com (7.221.188.194) by kwepemn100005.china.huawei.com (7.202.194.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Dec 2024 14:12:56 +0800 Received: from kwepemd500024.china.huawei.com ([7.221.188.194]) by kwepemd500024.china.huawei.com ([7.221.188.194]) with mapi id 15.02.1544.011; Tue, 10 Dec 2024 14:12:56 +0800 From: "Wangyunjian(wangyunjian,TongTu)" To: Jiawen Wu , "dev@dpdk.org" CC: "liwei (DT)" , "xiawei (H)" Subject: RE: txgbe: vlan offload setting errors Thread-Topic: txgbe: vlan offload setting errors Thread-Index: AdtKNXx1Xn6m+O8iR/CE1sVKf/HOugAAEb2wAAuaGoAAGZLQcA== Date: Tue, 10 Dec 2024 06:12:56 +0000 Message-ID: References: <8a4995861fb848aab7045c74949ae10b@huawei.com> <10c5f65918a64c92ae3c1e104f655d43@huawei.com> <05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com> In-Reply-To: <05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.242.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jiawen Wu [mailto:jiawenwu@trustnetic.com] > Sent: Tuesday, December 10, 2024 10:00 AM > To: Wangyunjian(wangyunjian,TongTu) ; > dev@dpdk.org > Cc: liwei (DT) ; xiawei (H) > Subject: RE: txgbe: vlan offload setting errors >=20 > > -----Original Message----- > > From: Wangyunjian(wangyunjian,TongTu) > > Sent: Monday, December 9, 2024 8:30 PM > > To: dev@dpdk.org; jiawenwu@trustnetic.com; jianwang@trustnetic.com > > Cc: liwei (DT) ; xiawei (H) > > Subject: txgbe: vlan offload setting errors > > > > Hello everyone, > > I recently added a txgbe port and enabled vlan offload. > > However, when I checked the dpdk logs, I noticed the following error: > "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set(): > > Please stop port first." >=20 > You should stop the device first, since VLAN offload cannot be changed wh= en Rx > ring is enabled. However, I haven't start the port yet. The port is new added. >=20 > > > > Upon reviewing the txgbe pmd driver code, I discovered that the variabl= e > hw->adapter_stopped is initially set to 0 and is not > changed > > to 1 in the device initialization function (eth_txgbe_dev_init). > > This causes an error in the txgbe_vlan_offload_set function, which chec= ks the > value of adapter_stopped and reports an error when > it > > is 0. >=20 > It was set to 1 in txgbe_stop_hw(). >=20 > > > > How can we fix this issue? Is it possible to set adapter_stopped to 1 i= n the > eth_txgbe_dev_init function? > > > > Best regards, > > Wei Li > >