From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] nfp: extend speed capabilities advertised Date: Mon, 19 Dec 2016 14:36:58 +0000 Message-ID: References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Alejandro Lucero , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 44339F932 for ; Mon, 19 Dec 2016 15:37:00 +0100 (CET) In-Reply-To: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Alejandro, On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > NFP supports more speeds than just 40 and 100GB, which were > what was advertised before. > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 27afbfd..77015c4 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1077,7 +1077,9 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw) > dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > > - dev_info->speed_capa = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_100G; > + dev_info->speed_capa = ETH_SPEED_NUM_1G | ETH_LINK_SPEED_10G | > + ETH_SPEED_NUM_25G | ETH_SPEED_NUM_40G | > + ETH_SPEED_NUM_50G | ETH_LINK_SPEED_100G; Does all devices driver by this driver supports all these speeds? I am aware of at least one exception to this, from previous patch [1], should we take that into account? Also other than that exception, can you please confirm all other devices support all above speeds? [1] + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) + link.link_speed = ETH_SPEED_NUM_40G; > } > > static const uint32_t * >