From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 2/3] app/testpmd: support creation of no IOVA contig mempools Date: Tue, 2 Apr 2019 16:15:30 +0100 Message-ID: References: <5db4de56-c5df-568a-431b-290dc60b9ec7@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Raslan Darawsheh , Thomas Monjalon , "ferruh.yigit@intel.com" To: Shahaf Shuler , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A66734CA7 for ; Tue, 2 Apr 2019 17:15:33 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02-Apr-19 8:02 AM, Shahaf Shuler wrote: > Monday, April 1, 2019 4:50 PM, Burakov, Anatoly: >> Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no >> IOVA contig mempools >> >> On 01-Apr-19 11:34 AM, Shahaf Shuler wrote: >>> providing a command line parameter to set the mempool flags accordingly. >>> This mode is relevant only when creating an empty mempool and then >>> populating with memory. >>> >>> Signed-off-by: Shahaf Shuler >>> --- >>> app/test-pmd/parameters.c | 5 +++++ >>> app/test-pmd/testpmd.c | 3 ++- >>> app/test-pmd/testpmd.h | 2 ++ >>> doc/guides/testpmd_app_ug/run_app.rst | 5 +++++ >>> 4 files changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>> index 7b6b60905d..ce0056b0bd 100644 >>> --- a/app/test-pmd/parameters.c >>> +++ b/app/test-pmd/parameters.c >>> @@ -202,6 +202,8 @@ usage(char* progname) >>> printf(" --noisy-lkup-num-writes=N: do N random writes per >> packet\n"); >>> printf(" --noisy-lkup-num-reads=N: do N random reads per >> packet\n"); >>> printf(" --noisy-lkup-num-writes=N: do N random reads and writes >>> per packet\n"); >>> + printf(" --no-iova-contig: mempool memory can be IOVA non >> contiguous. " >>> + "valid only with --mp-alloc=anon\n"); >> >> Maybe rather than spelling this out in the help message, it would be better >> to enforce it at option parse time, > > No problem, I can add. > >> and document it in the user guide? > > I think I did documents it. what is missing? Nothing, as it seems :) The user guide is fine. I just don't think we should explicitly reference other parameters in the help message, as it makes it harder to track down any changes/usages that may be needed. > > > >> >> -- >> Thanks, >> Anatoly -- Thanks, Anatoly