From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH v3 17/34] net/ice: support device and queue
	ops
Date: Wed, 12 Dec 2018 21:07:00 +0100
Message-ID: <cba1ea57-ab9f-4e3f-41cc-497e0d96a366@ericsson.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com>
 <1544598004-27099-18-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by dpdk.org (Postfix) with ESMTP id BD98B1B432
 for <dev@dpdk.org>; Wed, 12 Dec 2018 21:07:01 +0100 (CET)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 4DE9940019
 for <dev@dpdk.org>; Wed, 12 Dec 2018 21:07:01 +0100 (CET)
In-Reply-To: <1544598004-27099-18-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2018-12-12 07:59, Wenzhuo Lu wrote:

/../

> +
> +	for (i = 0; i < len * sizeof(union ice_rx_desc); i++)
> +		((volatile char *)rxq->rx_ring)[i] = 0;

More of a general question... but why doesn't DPDK has the 
READ/WRITE_ONCE() of the Linux kernel? Would reduce the amount of 
open-coded use of volatile.