From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 22/22] net/atlantic: documentation and rel
	notes
Date: Wed, 10 Oct 2018 11:29:50 +0100
Message-ID: <cbb18625-0067-702b-ac1b-debe1a8a365e@intel.com>
References: <cover.1539075891.git.igor.russkikh@aquantia.com>
 <d2f4da78cbd19e8d7a623a0f2481b78cc25ae1ce.1539075891.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Pavel Belous <Pavel.Belous@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id AD0161B47B
 for <dev@dpdk.org>; Wed, 10 Oct 2018 12:29:52 +0200 (CEST)
In-Reply-To: <d2f4da78cbd19e8d7a623a0f2481b78cc25ae1ce.1539075891.git.igor.russkikh@aquantia.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/9/2018 10:32 AM, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>

<...>

> @@ -0,0 +1,53 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +    Copyright(c) 2018 Aquantia Corporation.
> +
> +Aquantia Atlantic DPDK Driver
> +=============================
> +
> +Atlantic DPDK driver provides DPDK support for Aquantia's AQtion family of chipsets: AQC107/AQC108/AQC109

Can you please provide links to the devices mentioned?

<...>

> @@ -0,0 +1,37 @@
> +;
> +; Supported features of the 'atlantic' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Speed capabilities   = Y
> +Link status          = Y
> +Link status event    = Y
> +MTU update           = Y
> +Jumbo frame          = Y
> +Promiscuous mode     = Y
> +Allmulticast mode    = Y
> +Unicast MAC filter   = Y
> +VLAN filter          = Y
> +Flow control         = Y
> +CRC offload          = Y
> +VLAN offload         = Y
> +L3 checksum offload  = Y
> +L4 checksum offload  = Y
> +Rx descriptor status = Y
> +Tx descriptor status = Y
> +Basic stats          = Y
> +Extended stats       = Y
> +Stats per queue      = Y
> +Linux UIO            = Y
> +x86-32               = Y
> +x86-64               = Y
> +Queue start/stop     = Y
> +RSS hash             = Y
> +RSS key update       = Y
> +RSS reta update      = Y
> +Packet type parsing  = Y
> +FW version           = Y
> +EEPROM dump          = Y
> +Registers dump       = Y
> +LED                  = Y

Can you please distribute this file to the patchset, update the relevant item in
the patch that enables this feature, so that it becomes kind of documentation
and help to track the code which enabled a feature.

And please keep the order of the default.ini