From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] kni: fix ethtool build with kernel 4.11
Date: Wed, 3 May 2017 17:43:04 +0100
Message-ID: <cc0171a5-8a6e-11a6-d8e0-ae4b3fa52c4c@intel.com>
References: <20170503160016.31375-1-ferruh.yigit@intel.com>
 <d2cc241a-52d6-a332-24d0-69eb64e0f55e@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: nicolas.dichtel@6wind.com, Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 018F637A2
 for <dev@dpdk.org>; Wed,  3 May 2017 18:43:07 +0200 (CEST)
In-Reply-To: <d2cc241a-52d6-a332-24d0-69eb64e0f55e@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/3/2017 5:39 PM, Nicolas Dichtel wrote:
> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit :
>> build error:
>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
>> error: implicit declaration of function ‘pci_enable_msix’
>> [-Werror=implicit-function-declaration]
>>     err = pci_enable_msix(pdev,
>>               ^~~~~~~~~~~~~~~
>>
>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option
>> enabled.
>>
>> Following Linux commit removes the pci_enable_msix()
>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
>>
>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
>> igb driver uses this function.
> When looking at the kernel patches, it seems that the way to go is to use
> pci_alloc_irq_vectors(), but it needs a bit more work.

I remember this from your igb_uio fix, but latest igb kernel driver uses
pci_enable_msix_range(), I found it easy and safe to replicate it.

We can update it when kernel igb driver updates the code, unless you
have a strong opinion to switch pci_alloc_irq_vectors() in advance?

Thanks,
ferruh

> 
> Exemple :
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da6f4cf58e40
> 
> 
> Regards,
> Nicolas
>