From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3] vhost: Add indirect descriptors support to the TX path Date: Tue, 27 Sep 2016 09:25:48 +0200 Message-ID: References: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com> <20160927041555.GC25823@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: huawei.xie@intel.com, dev@dpdk.org, vkaplans@redhat.com, mst@redhat.com, stephen@networkplumber.org To: Yuanhan Liu Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CD6362BA6 for ; Tue, 27 Sep 2016 09:25:51 +0200 (CEST) In-Reply-To: <20160927041555.GC25823@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/27/2016 06:15 AM, Yuanhan Liu wrote: > On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: >> + if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { >> + desc = (struct vring_desc *)gpa_to_vva(dev, > > As mentioned before, this would break 32 bit OS build. It should be > > (struct vring_desc *)(uintptr_t)gpa_to_vva(...); > > I meant to fix this while apply, later I just realized you haven't > updated the release note (sorry for the late notice). > > So would you mind send a new version, with the fix and release note > update? FYI, the release note is at "doc/guides/rel_notes/" Not a problem, doing it now. Thanks, Maxime