From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1 Date: Mon, 19 Nov 2018 13:27:39 +0000 Message-ID: References: <1542219449-7393-1-git-send-email-rasesh.mody@cavium.com> <1542447449-19888-2-git-send-email-rasesh.mody@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" , Dept-Eng DPDK Dev To: "Mody, Rasesh" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 031542BD5 for ; Mon, 19 Nov 2018 14:27:41 +0100 (CET) In-Reply-To: <1542447449-19888-2-git-send-email-rasesh.mody@cavium.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/17/2018 9:37 AM, Mody, Rasesh wrote: > Signed-off-by: Rasesh Mody Hi Rasesh, 18.11-rc4 is out and this patchset was late for it, I suggest postponing previous patch, `cleanup info logs`, in to next release (v19.02) But not sure about this patch, I guess this is to mark the changes in this release, it looks like there is no API using this information so applications don't require version information but it is just for logging. Can you please advise on to get or postpone this version update patch (without getting other patch in the series) ? > --- > drivers/net/bnx2x/bnx2x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > index c80f84c..4c775c1 100644 > --- a/drivers/net/bnx2x/bnx2x.c > +++ b/drivers/net/bnx2x/bnx2x.c > @@ -29,7 +29,7 @@ > #define BNX2X_PMD_VER_PREFIX "BNX2X PMD" > #define BNX2X_PMD_VERSION_MAJOR 1 > #define BNX2X_PMD_VERSION_MINOR 0 > -#define BNX2X_PMD_VERSION_REVISION 6 > +#define BNX2X_PMD_VERSION_REVISION 7 > #define BNX2X_PMD_VERSION_PATCH 1 > > static inline const char * >