From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/i40e: consider QinQ when setting MTU Date: Fri, 28 Apr 2017 06:55:23 +0100 Message-ID: References: <1493344523-58766-1-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Wenzhuo Lu , dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F04FB9E3 for ; Fri, 28 Apr 2017 07:55:27 +0200 (CEST) In-Reply-To: <1493344523-58766-1-git-send-email-wenzhuo.lu@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/28/2017 2:55 AM, Wenzhuo Lu wrote: > When counting max packet length from MTU, count > VLAN tag length twice for QinQ packets. > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 3fa25dc..74041ae 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -10593,7 +10593,7 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, > struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > struct rte_eth_dev_data *dev_data = pf->dev_data; > uint32_t frame_size = mtu + ETHER_HDR_LEN > - + ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE; > + + ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2; Hi Wenzhuo, Shouldn't we check if QinQ enabled before taking size account?