From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 01/17] vhost: introduce driver features
	related APIs
Date: Tue, 14 Mar 2017 10:46:35 +0100
Message-ID: <cd83e9e3-426d-c936-a666-625dcfa9fe59@redhat.com>
References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1488534682-3494-2-git-send-email-yuanhan.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Harris James R <james.r.harris@intel.com>,
 Liu Changpeng <changpeng.liu@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 7793D69F7
 for <dev@dpdk.org>; Tue, 14 Mar 2017 10:46:41 +0100 (CET)
In-Reply-To: <1488534682-3494-2-git-send-email-yuanhan.liu@linux.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 03/03/2017 10:51 AM, Yuanhan Liu wrote:
> Introduce few APIs to set/get/enable/disable driver features.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
>  lib/librte_vhost/rte_vhost_version.map | 10 ++++
>  lib/librte_vhost/rte_virtio_net.h      |  9 ++++
>  lib/librte_vhost/socket.c              | 90 ++++++++++++++++++++++++++++++++++
>  3 files changed, 109 insertions(+)

Nice!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I wonder whether we could protect from setting/enabling/disabling
features once negotiation is done?

Thanks,
Maxime