From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] drivers/net: fix shifting 32-bit signed
 variable 31 times
Date: Tue, 26 Feb 2019 10:31:04 +0000
Message-ID: <cdb49be3-c07a-da22-df2b-e912f8e3b927@intel.com>
References: <1550582690-29533-1-git-send-email-andrius.sirvys@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org, stephen@networkplumber.org, shaguna@chelsio.com,
 rasesh.mody@qlogic.com, ophirmu@mellanox.com
To: Andrius Sirvys <andrius.sirvys@intel.com>, dev@dpdk.org,
 Ravi Kumar <ravi1.kumar@amd.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Keith Wiles <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1550582690-29533-1-git-send-email-andrius.sirvys@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/19/2019 1:24 PM, Andrius Sirvys wrote:
> Shifting signed 32-bit values by 31-bits has the potential for
> unexpected  outcomes as compiler can overwrite a bit.
> Specified that values are unsigned.
> 
> Errors are observed from running cppcheck.
> 
> Bugzilla ID: 58
> Fixes: 69e209be5464 ("net/axgbe: add register map and related macros")
> Fixes: b5bf7719221d ("bnx2x: driver support routines")
> Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats")
> Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table")
> Fixes: bdb244b96920 ("e1000: whitespace changes")
> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
> Fixes: ec94dbc57362 ("qede: add base driver")
> Fixes: d2e7d931d0ad ("net/qede/base: formatting changes")
> Fixes: cdc07e83bb24 ("net/tap: add eBPF program file")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>