From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3912FECE58E for ; Thu, 17 Oct 2019 16:00:09 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 01DA521835 for ; Thu, 17 Oct 2019 16:00:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01DA521835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 548881EA26; Thu, 17 Oct 2019 18:00:08 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8F22C1EA21 for ; Thu, 17 Oct 2019 18:00:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 09:00:05 -0700 X-IronPort-AV: E=Sophos;i="5.67,308,1566889200"; d="scan'208";a="371177107" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.107]) ([10.237.221.107]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 17 Oct 2019 09:00:03 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: Marcin Baran , john.mcnamara@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com References: From: "Hunt, David" Message-ID: Date: Thu, 17 Oct 2019 17:00:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 07/10] distributor: rename v2.0 ABI to _single suffix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/10/2019 15:31, Anatoly Burakov wrote: > From: Marcin Baran > > The original ABI versioning was slightly misleading in that the > DPDK 2.0 ABI was really a single mode for the distributor, and is > used as such throughout the distributor code. > > Fix this by renaming all _v20 API's to _single API's, and remove > symbol versioning. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > --- > > Notes: > v4: > - Changed it back to how it was with v2 > - Removed remaining v2.0 symbols > > v3: > - Removed single mode from distributor as per Dave's comments > > v2: > - Moved this to before ABI version bump to avoid compile breakage > Hi Anatoly,     tested with Distributor sample app, Unit tests, looks good. Acked-by: David Hunt