From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 3/5] net/virtio: remove a redundant macro definition for ctrl vq Date: Thu, 7 Dec 2017 10:16:21 +0100 Message-ID: References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-4-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Tiwei Bie , yliu@fridaylinux.org, dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5E9D51C00 for ; Thu, 7 Dec 2017 10:16:31 +0100 (CET) In-Reply-To: <20171207053059.19487-4-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/07/2017 06:30 AM, Tiwei Bie wrote: > VIRTIO_NET_CTRL_MAC_ADDR_SET is defined two times in > virtqueue.h, the second one is obviously not wanted. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtqueue.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index ab466c2db..eaf9de13e 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -226,8 +226,6 @@ struct virtqueue { > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN 1 > #define VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX 0x8000 > > -#define VIRTIO_NET_CTRL_MAC_ADDR_SET 1 > - > /** > * This is the first element of the scatter-gather list. If you don't > * specify GSO or CSUM features, you can simply ignore the header. > Reviewed-by: Maxime Coquelin Thanks, Maxime