From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v10 05/19] eal: enable hotplug on multi-process Date: Wed, 11 Jul 2018 09:39:25 +0100 Message-ID: References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180709033706.27858-1-qi.z.zhang@intel.com> <20180709033706.27858-6-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E70611532586BA@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611532586FE@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Shelton, Benjamin H" , "Vangati, Narender" To: "Zhang, Qi Z" , "thomas@monjalon.net" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 000FC1B4FD for ; Wed, 11 Jul 2018 10:39:28 +0200 (CEST) In-Reply-To: <039ED4275CED7440929022BC67E70611532586FE@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Jul-18 3:11 AM, Zhang, Qi Z wrote: >>>> +/* Max length for a bus name */ >>>> +#define RTE_BUS_NAME_MAX_LEN 32 >>> >>> Is this enforced anywhere in the bus codebase? Can we guarantee that >>> bus name will never be bigger than this? >> >> I think 32 should be enough for a bus name even in future. > > Sorry, I missed your point, I think it is not enforced, we still can add a new bus exceed 32, > but for RTE_DEV_NAME_MAX_LEN which is used in rte_devargs to enforce all device name not exceed 64. > So, it's better to move RTE_BUS_NAME_MAX_LEN into hotplug_mp as internal , and this can be regarded as a limitation for hotplug so far, though it should be enough for all exist cases. > And same for RTE_DEV_ARGS_MAX_LEN. Can we fix it in this patchset, or would that involve an ABI break of some sort? -- Thanks, Anatoly