DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
	dev@dpdk.org, "Thomas Monjalon" <thomas@monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] stack: fix pile GCC memcpy warnings
Date: Tue, 20 Oct 2026 13:18:35 +0300	[thread overview]
Message-ID: <ce649de7-fac8-49c7-b756-9aafde5764e3@nvidia.com> (raw)
In-Reply-To: <20261020084944.3188987-1-mb@smartsharesystems.com>

On 10/20/26 11:49 AM, Morten Brørup wrote:

> On architectures where rte_memcpy() is defined as memcpy(),
> GCC warns about source/destination overflow when copying more than the
> source/destination size, even for code paths that are not taken in cases
> where the sizes are smaller.
>
> The relevant compiler warnings were disabled for GCC at the two
> occurrences, and comments describing the reason were added.
>
> NB:
> It has not been investigated which GCC versions are affected.
> GCC version 10 and up was chosen because that was what the previous
> versions of x86 rte_memcpy() disabled sligthly similar warnings for.
>
> PS:
> The alternative was to obfuscate the code, but that would make the code
> less readable, and might have unintended effects on architectures and
> compilers not suffering by this issue.
>
> Bugzilla ID: 2061
> Fixes: ee0822a0ef41 ("stack: introduce pile")
>
> The pile was introduce with this DPDK release, so no need to backport.
>
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> ---

Build passes with this patch.

Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks,
Ali


  parent reply	other threads:[~2026-10-20 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  8:49 [PATCH] stack: fix pile GCC memcpy warnings Morten Brørup
2026-10-20  9:18 ` Bruce Richardson
2026-10-20  9:59   ` Morten Brørup
2026-10-20 10:18 ` Ali Alnubani [this message]
2026-10-20 14:23 ` Stephen Hemminger
2026-10-20 15:16   ` Morten Brørup
2026-10-20 15:39     ` Morten Brørup
2026-10-20 14:34 ` Stephen Hemminger
2026-10-20 15:27   ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce649de7-fac8-49c7-b756-9aafde5764e3@nvidia.com \
    --to=alialnu@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox