From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3] netvsc: resize event buffer as needed Date: Thu, 23 Aug 2018 16:59:43 +0100 Message-ID: References: <20180814164525.10703-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger To: Stephen Hemminger , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DAA482BF7 for ; Thu, 23 Aug 2018 17:59:54 +0200 (CEST) In-Reply-To: <20180814164525.10703-1-stephen@networkplumber.org> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/14/2018 5:45 PM, Stephen Hemminger wrote: > The event buffer was changed to be a fixed size value, > had a couple of issues. The big one is that rte_free was still > being called for a pointer that was not setup with rte_malloc(). > > The event buffer was also too small to handle heavy receive > traffic; and running the event buffer out would crash > the application. > > Fix by going back to a dynamically resized event buffer. > And grow it by 25% to avoid lots of realloc's. > > Fixes: 530af95a7849 ("bus/vmbus: avoid signalling host on read") > Signed-off-by: Stephen Hemminger Cc: stable@dpdk.org Applied to dpdk-next-net/master, thanks.