From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH 3/3] examples/ipsec_secgw: create session
 mempools for ethdevs
Date: Mon, 15 Jan 2018 10:41:09 +0000
Message-ID: <cf3680c8-66e9-b3b5-6be6-fa72cd6446d5@intel.com>
References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com>
 <1513083027-11741-3-git-send-email-radu.nicolau@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC69863@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "Doherty, Declan" <declan.doherty@intel.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 3B5BA2C6E
 for <dev@dpdk.org>; Mon, 15 Jan 2018 11:41:13 +0100 (CET)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC69863@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 1/8/2018 11:03 AM, De Lara Guarch, Pablo wrote:
>
>> -----Original Message-----
>> From: Nicolau, Radu
>> Sent: Tuesday, December 12, 2017 12:50 PM
>> To: dev@dpdk.org
>> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; Gonzalez Monroy, Sergio
>> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
>> <declan.doherty@intel.com>; akhil.goyal@nxp.com; Nicolau, Radu
>> <radu.nicolau@intel.com>
>> Subject: [PATCH 3/3] examples/ipsec_secgw: create session mempools for
>> ethdevs
>>
>> Also moved offloaded packets from cryptodev queues
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
>>   examples/ipsec-secgw/ipsec-secgw.c | 42
>> +++++++++++++++++++++++++++++++++++++-
>>   examples/ipsec-secgw/ipsec.c       | 31 ++++++++++++++--------------
>>   examples/ipsec-secgw/ipsec.h       |  4 ++--
>>   3 files changed, 58 insertions(+), 19 deletions(-)
>>
>> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
>> secgw/ipsec-secgw.c
>> index c98454a..08d5b5a 100644
>> --- a/examples/ipsec-secgw/ipsec-secgw.c
>> +++ b/examples/ipsec-secgw/ipsec-secgw.c
>> @@ -1244,7 +1244,7 @@ cryptodevs_init(void)
>>   	struct rte_cryptodev_config dev_conf;
>>   	struct rte_cryptodev_qp_conf qp_conf;
>>   	uint16_t idx, max_nb_qps, qp, i;
>> -	int16_t cdev_id;
>> +	int16_t cdev_id, port_id;
> These two variables should be uint16_t (port_id is actually uint8_t).
If unsigned then line <for (cdev_id = rte_cryptodev_count() - 1; cdev_id 
 >= 0; cdev_id--)> will not work correctly.
>
> For the rest of the patch: Akhil, could you review it?
>
> Thanks,
> Pablo