From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E23BCA9EAF for ; Thu, 24 Oct 2019 11:14:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 10CF620684 for ; Thu, 24 Oct 2019 11:14:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10CF620684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6ECD81E915; Thu, 24 Oct 2019 13:14:02 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AFB3E1E8ED for ; Thu, 24 Oct 2019 13:14:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 04:13:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,224,1569308400"; d="scan'208";a="210132641" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.8.129]) ([10.252.8.129]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2019 04:13:58 -0700 To: David Marchand Cc: Li Han , Thomas Monjalon , dev References: <1571827361-30578-1-git-send-email-han.li1@zte.com.cn> From: "Burakov, Anatoly" Message-ID: Date: Thu, 24 Oct 2019 12:13:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24-Oct-19 8:37 AM, David Marchand wrote: > On Wed, Oct 23, 2019 at 7:47 PM Burakov, Anatoly > wrote: >> >> On 23-Oct-19 11:42 AM, Li Han wrote: >>> In rte_eal_config_reattach(),the secondary mmap may fail >>> due to the rte_mem_cfg_addr already be used by others.do >>> the change just as the rte_fbarray_init() do.if no >>> base_virtaddr,use the default 0x100000000. >>> >>> v2/v3: >>> -fix code style issues >>> >>> Signed-off-by: Li Han >>> --- >> >> Nack. There's a reason why we map it at the same address, and it's to >> have all pointers working across processes. Remapping it at a different >> address has potential to break things. > > Marked as rejected. > Thanks. > Hi David, My apologies, I've misinterpreted the intent of the patch. I am rescinding my NACK. -- Thanks, Anatoly