From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] app/crypto-perf: fix uninitialized errno
	value
Date: Tue, 5 Sep 2017 11:33:12 +0530
Message-ID: <cf536404-34dc-a40b-b6e7-ec193d116335@nxp.com>
References: <1503491044-27863-1-git-send-email-hemant.agrawal@nxp.com>
 <1503491044-27863-2-git-send-email-hemant.agrawal@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC15612@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Doherty, Declan" <declan.doherty@intel.com>, "akhil.goyal@nxp.com"
 <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0040.outbound.protection.outlook.com [104.47.37.40])
 by dpdk.org (Postfix) with ESMTP id 0D60F293B
 for <dev@dpdk.org>; Tue,  5 Sep 2017 08:03:18 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC15612@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/4/2017 8:26 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
>> Sent: Wednesday, August 23, 2017 1:24 PM
>> To: dev@dpdk.org
>> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
>> Subject: [PATCH] app/crypto-perf: fix uninitialized errno value
>>
>> errno should be initialized to 0 before calling strtol
>>
>> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>  app/test-crypto-perf/cperf_options_parsing.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-
>> perf/cperf_options_parsing.c
>> index 085aa8f..77c405c 100644
>> --- a/app/test-crypto-perf/cperf_options_parsing.c
>> +++ b/app/test-crypto-perf/cperf_options_parsing.c
>> @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min,
>> uint32_t *max, uint32_t *inc)
>>  	if (copy_arg == NULL)
>>  		return -1;
>>
>> +	errno = 0;
>>  	token = strtok(copy_arg, ":");
>>
>>  	/* Parse minimum value */
>> --
>> 2.7.4
>
> Could you extend this fix to the parse_list function?
>
> Thanks!
> Pablo
>
sure.